Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates Angular UI components from the decorator-based @Input() pattern to the newer signals-based input() API, removes empty ngOnInit lifecycle hooks, and adds error handling to the dashboard's data fetching.
Changes:
- Migrated
BannerComponent,BreadcrumbsComponent, andIpAddressButtonComponentfrom@Input()decorators to signal-basedinput(), updating templates to call signals as functions. - Added a
Breadcrumbinterface and replaced*ngFor/*ngIfstructural directives with@for/@ifcontrol flow in the breadcrumbs template. - Added error callback to
fetchTablesFolderssubscription inDashboardComponentand removed debugconsole.logcalls.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ip-address-button.component.ts | Migrated to input() signal and inject() |
| ip-address-button.component.html | Updated template to call ip() |
| breadcrumbs.component.ts | Migrated to input() signal, added Breadcrumb interface, removed CommonModule |
| breadcrumbs.component.html | Replaced structural directives with @for/@if control flow |
| banner.component.ts | Migrated to input() signal |
| banner.component.html | Updated template to call type() |
| dashboard.component.ts | Added error handler, removed debug logs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+215
to
221
| }, | ||
| (err) => { | ||
| this.isServerError = true; | ||
| this.serverError = { abstract: err.error?.message || err.message, details: err.error?.originalMessage }; | ||
| this.loading = false; | ||
| this.title.setTitle(`Error | ${this._company.companyTabTitle || 'Rocketadmin'}`); | ||
| }); |
| }); | ||
| } | ||
| }, | ||
| (err) => { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.